Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Feature] Add project level API to return the global settings #2322

Closed
2 tasks done
pmahindrakar-oss opened this issue Apr 5, 2022 · 6 comments
Closed
2 tasks done
Assignees
Labels
flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free needs discussion ui Admin console user interface
Milestone

Comments

@pmahindrakar-oss
Copy link
Contributor

Describe the issue

With this issue #2070
Project domain settings have been added for execution config and which will be shown in the UI on the domain landing page.

We also need Project level global settings which the user can view

What if we do not do this?

User wont be aware of global config which can get used in the absence of project-domain settings

Related component(s)

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pmahindrakar-oss pmahindrakar-oss added flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free labels Apr 5, 2022
@pmahindrakar-oss pmahindrakar-oss added this to the 1.0.1 milestone Apr 5, 2022
@pmahindrakar-oss pmahindrakar-oss self-assigned this Apr 5, 2022
@katrogan
Copy link
Contributor

katrogan commented Apr 6, 2022

hey @pmahindrakar-oss can you expand on what is a project-level global setting? do you mean the default settings at the per-domain level in the config?

@pmahindrakar-oss
Copy link
Contributor Author

pmahindrakar-oss commented Apr 7, 2022

Hi @katrogan
So if you check the UX here https://www.figma.com/file/s06CbgfgMMJjeDPxORhOJU/Flyte-Console we have a domain setting global which is nothing but project level default settings that get applied to all domains.

project-domain through matchable attributes provides an override for this behavior which we now have in flyteadmin.
This ticket is track the project level default settings. And this would be something we want to introduce in the Project level api and subsequently have that api also return list of all domain along with their overrides

Let me know if that makes senses

@katrogan
Copy link
Contributor

katrogan commented Apr 7, 2022

yeah thanks for clarifying, i think i got thrown off b/c the hierarchy is domain -> domain/project -> ... but I see this is just a way to expose the default/domain settings, makes sense!

@pmahindrakar-oss
Copy link
Contributor Author

@pmahindrakar-oss
Copy link
Contributor Author

@wild-endeavor wild-endeavor changed the title [Housekeeping] Add project level API to return the global settings [Core Feature] Add project level API to return the global settings Jun 29, 2022
@eapolinario eapolinario modified the milestones: 1.2.0, 1.3.0 Sep 14, 2022
@cosmicBboy cosmicBboy modified the milestones: 1.3.0, 2023 Q1 Backlog Jan 25, 2023
@cosmicBboy cosmicBboy modified the milestones: 2023 Q1 Backlog, 1.4.0 Feb 6, 2023
@cosmicBboy cosmicBboy added the ui Admin console user interface label Feb 8, 2023
@jsonporter
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free needs discussion ui Admin console user interface
Projects
None yet
Development

No branches or pull requests

7 participants