Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] [Pod plugin] UX and example improvements #3196

Closed
2 tasks done
kumare3 opened this issue Dec 29, 2022 · 2 comments
Closed
2 tasks done

[Core feature] [Pod plugin] UX and example improvements #3196

kumare3 opened this issue Dec 29, 2022 · 2 comments
Labels
enhancement New feature or request flytekit FlyteKit Python related issue
Milestone

Comments

@kumare3
Copy link
Contributor

kumare3 commented Dec 29, 2022

Motivation: Why do you think this is important?

Example for using Pod features is overly complicated.

Also the pod plugin does not make it simply possible to add pod-spec related features like node-selector etc.

it is possible to do this

 @task(
        task_config=Pod(
            pod_spec=V1PodSpec(
                containers=[],
                node_selector={"node_group": "memory"},
            ),
        ),
        requests=Resources(
            mem="1G",
        ),
    )
    def my_pod_task():
        ...

Goal: What should the final outcome look like, ideally?

Improve the example and point to the new pod plugin

Describe alternatives you've considered

NA

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Dec 29, 2022
@eapolinario eapolinario added flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Dec 30, 2022
@eapolinario eapolinario added this to the 1.3.0 milestone Dec 30, 2022
@cosmicBboy cosmicBboy modified the milestones: 1.3.0, 2023 Q1 Backlog Jan 25, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Oct 23, 2023
Copy link

github-actions bot commented Nov 1, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

3 participants