Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [CONSOLE] gate node in dynamic task #3354

Closed
2 tasks done
wild-endeavor opened this issue Feb 17, 2023 · 2 comments · Fixed by flyteorg/flyteconsole#729
Closed
2 tasks done

[BUG] [CONSOLE] gate node in dynamic task #3354

wild-endeavor opened this issue Feb 17, 2023 · 2 comments · Fixed by flyteorg/flyteconsole#729
Assignees
@james-union
Labels
bug Something isn't working Epic: Signaling Signal support, gate nodes, and HITL workflows ui Admin console user interface
Milestone
1.5.0

Comments

@wild-endeavor
Copy link
Contributor

wild-endeavor commented Feb 17, 2023 •
edited by jsonporter
Loading

Describe the bug

Gate nodes inside of dynamic tasks don't behave the same. This workflow https://github.com/flyteorg/flytesnacks/blob/cecf8b1c98b784da3f15c1ab04624619890d1d16/cookbook/core/control_flow/human_in_the_loop.py#L82 is functionally the same as the mainwf that we've been testing on, except that it happens inside a dynamic task instead of the top level workflow.

However when run inside a dynamic workflow, things don't look the same. None of the gate node stuff is there and the approval node only shows Running not Paused.

image

Expected behavior

Things should look the same as the non-dynamic case. This includes all views (node-list, graph, timeline)

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@wild-endeavor wild-endeavor added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers ui Admin console user interface Epic: Signaling Signal support, gate nodes, and HITL workflows labels Feb 17, 2023
@cosmicBboy cosmicBboy added this to the 1.5.0 milestone Mar 9, 2023
@cosmicBboy cosmicBboy removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 9, 2023
@cosmicBboy
Copy link
Contributor

@jsonporter just assigned @james-union to work on this for the 1.5.0 release.

@cosmicBboy cosmicBboy mentioned this issue Mar 9, 2023
Closed
13 tasks
@cosmicBboy
Copy link
Contributor

@jsonporter @james-union this PR: flyteorg/flytesnacks#968 contains code that you can use to work on this issue (basically the dyn @dynamic workflow)

@cosmicBboy cosmicBboy mentioned this issue Mar 10, 2023
Open
2 tasks
@jsonporter jsonporter removed their assignment Mar 17, 2023
@james-union james-union mentioned this issue Mar 22, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@james-union james-union

Labels
bug Something isn't working Epic: Signaling Signal support, gate nodes, and HITL workflows ui Admin console user interface
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

gate node in dynamic task flyteorg/flyteconsole
4 participants
@cosmicBboy @wild-endeavor @jsonporter @james-union