Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Spark, Ray, Dask plugins should support pod_template and pod_template_name arguments #3414

Closed
2 of 8 tasks
cosmicBboy opened this issue Mar 7, 2023 · 2 comments
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers

Comments

@cosmicBboy
Copy link
Contributor

Motivation: Why do you think this is important?

Similar to flyteorg/flytekit#1515, we want to add support for the new pod template configuration for the spark, ray, and dask plugins:

Goal: What should the final outcome look like, ideally?

Each of the plugins mentioned above needs to accept pod_template and pod_template_name arguments, like the ContainerTask PR, with documentation updates in the Spark, Ray, and Dask integration examples.

Describe alternatives you've considered

NA

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Mar 7, 2023
@hamersaw
Copy link
Contributor

hamersaw commented Mar 8, 2023

@cosmicBboy we should close this issue, or at least reword it significantly because it is very misleading. There does not need to be any changes to flytekit for any of these plugins to support the new PodTemplate work. In addition, it is not clear that this is useful with Spark.

@cosmicBboy
Copy link
Contributor Author

cool, closing this now. @hamersaw would you mind creating a new issue with the correct scope?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

2 participants