Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between cache disabled and cache put failure #3430

Closed
hamersaw opened this issue Jan 17, 2023 · 2 comments · Fixed by flyteorg/flyteconsole#719
Closed

Differentiate between cache disabled and cache put failure #3430

hamersaw opened this issue Jan 17, 2023 · 2 comments · Fixed by flyteorg/flyteconsole#719
Assignees
@jsonporter @james-union
Milestone
1.5.0

Comments

@hamersaw
Copy link
Contributor

A user has a cache put failure which we can confirm is set in the admin DB as the correct code. However, when it is displayed in the UI, the icon is the same as the "cache disabled" icon and hovering displays as such. It would be useful if there were visual differentiation between these two status'.
@cosmicBboy
Copy link
Contributor

will need to add a new icon for "cache disabled" vs "cache put failure" if we don't have one already

@jsonporter jsonporter transferred this issue from flyteorg/flyteconsole Mar 9, 2023
@jsonporter jsonporter added this to the 1.5.0 milestone Mar 9, 2023
@james-union
Copy link

image
@jsonporter @hamersaw Does this look good?

@james-union james-union mentioned this issue Mar 10, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsonporter jsonporter

@james-union james-union

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

feat: differentiate between cache disabled and cache put failure flyteorg/flyteconsole
4 participants
@cosmicBboy @hamersaw @jsonporter @james-union