[BUG] flytekit should support the flytectl config.yaml "admin.clientSecretEnvVar" option #3482
Open
2 tasks done
Labels
bug
Something isn't working
flytekit
FlyteKit Python related issue
good first issue
Good for newcomers
help wanted
Extra attention is needed
scipy-2023
stale
Describe the bug
For context,
pyflyte run
andpyflyte register
use the flytectl config.yaml file for various configuration settings, including client credential secret. The purpose of this issue is to support theclientSecretEnvVar
key, which reads the credential from the specified environment variable.Currently, flytekit supports the
clientSecretLocation
key, but not theclientSecretEnvVar
: https://github.com/flyteorg/flytekit/blob/master/flytekit/configuration/__init__.py#L401-L411Steps:
admin.clientSecretEnvVar
into the platform configclientSecretLocation
orclientSecretEnvVar
is set, automatically setauth_mode
toclientSecret
(this is so we match the UnionCloud behavior, see here)Expected behavior
client-secret-based authentication should work with
admin.clientSecretEnvVar
in the flytectl config.yamlAdditional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: