Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] flytekit should support the flytectl config.yaml "admin.clientSecretEnvVar" option #3482

Open
2 tasks done
cosmicBboy opened this issue Mar 16, 2023 · 3 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue good first issue Good for newcomers help wanted Extra attention is needed scipy-2023 stale

Comments

@cosmicBboy
Copy link
Contributor

Describe the bug

For context, pyflyte run and pyflyte register use the flytectl config.yaml file for various configuration settings, including client credential secret. The purpose of this issue is to support the clientSecretEnvVar key, which reads the credential from the specified environment variable.

admin:
  endpoint: dns:///<your-org.hosted.unionai.cloud>
  clientId: <client-id-from-app-creation>
  # If the secret will be mounted as a file:
  clientSecretLocation: /home/.../<ci-secret>
  # Or, if the secret will be mounted as an environment variable
  clientSecretEnvVar: <env-var>
logger:
  # Logger settings to control logger output. Useful to debug logger:
  show-source: true
  level: 1

Currently, flytekit supports the clientSecretLocation key, but not the clientSecretEnvVar: https://github.com/flyteorg/flytekit/blob/master/flytekit/configuration/__init__.py#L401-L411

Steps:

  • Support reading admin.clientSecretEnvVar into the platform config
  • If clientSecretLocation or clientSecretEnvVar is set, automatically set auth_mode to clientSecret (this is so we match the UnionCloud behavior, see here)

Expected behavior

client-secret-based authentication should work with admin.clientSecretEnvVar in the flytectl config.yaml

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Mar 16, 2023
@eapolinario eapolinario added flytekit FlyteKit Python related issue good first issue Good for newcomers help wanted Extra attention is needed and removed untriaged This issues has not yet been looked at by the Maintainers labels Mar 24, 2023
@chaohengstudent
Copy link
Contributor

Hi @cosmicBboy , I am interested in this issue. Can I work on this?

@zeryx
Copy link

zeryx commented Sep 6, 2023

hey @cosmicBboy @chaohengstudent Any progress on this?
We're documenting this feature, and would like to avoid having to describe workarounds for current bugs that are in progress.

Copy link

github-actions bot commented Jun 3, 2024

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue good first issue Good for newcomers help wanted Extra attention is needed scipy-2023 stale
Projects
None yet
Development

No branches or pull requests

4 participants