Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support from structured datasets #801

Merged
merged 4 commits into from
Jul 25, 2023
Merged

feat: add support from structured datasets #801

merged 4 commits into from
Jul 25, 2023

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Jul 25, 2023

TL;DR

add support from structured datasets

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added support for structured datasets in the launch form

Before:

image

After:

image

Tracking Issue

closes flyteorg/flyte#3892
closes flyteorg/flyte#3395

Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina requested review from a team, FrankFlitton, jsonporter and 4nalog and removed request for a team July 25, 2023 20:11
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina enabled auto-merge (squash) July 25, 2023 20:54
Signed-off-by: Carina Ursu <carina@union.ai>
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #801 (20a0ab9) into master (a7ba08a) will decrease coverage by 0.27%.
Report is 2 commits behind head on master.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
- Coverage   67.16%   66.90%   -0.27%     
==========================================
  Files         499      501       +2     
  Lines       12217    12293      +76     
  Branches     2247     2262      +15     
==========================================
+ Hits         8206     8225      +19     
- Misses       4011     4068      +57     
Files Changed Coverage Δ
...tions/ExecutionDetails/NodeExecutionTabs/index.tsx 74.46% <ø> (ø)
...components/Executions/ExecutionDetails/strings.tsx 100.00% <ø> (ø)
.../src/components/Executions/nodeExecutionQueries.ts 39.37% <ø> (-0.42%) ⬇️
...sole/src/components/Launch/LaunchForm/constants.ts 100.00% <ø> (ø)
...nents/Launch/LaunchForm/inputHelpers/collection.ts 54.83% <ø> (ø)
...ponents/Launch/LaunchForm/inputHelpers/datetime.ts 90.47% <0.00%> (ø)
...components/Launch/LaunchForm/inputHelpers/float.ts 89.47% <0.00%> (ø)
...omponents/Launch/LaunchForm/inputHelpers/string.ts 73.68% <0.00%> (ø)
...components/Launch/LaunchForm/inputHelpers/union.ts 50.00% <0.00%> (ø)
...onsole/src/components/Launch/LaunchForm/strings.ts 100.00% <ø> (ø)
... and 16 more

@ursucarina ursucarina merged commit 16abb34 into master Jul 25, 2023
@ursucarina ursucarina deleted the carina/sds branch July 25, 2023 21:37
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support from structured datasets [BUG] FE: Structured data sets not working from launch form
3 participants