Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commit linter running on generated messages #810

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

FrankFlitton
Copy link
Contributor

TL;DR

Commit linter was running on auto-generated content with long URLs to github artifacts, triggering the lines longer than 100 chars rule.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Made sure CI env variable was set - same as linter stage - that it was bypassing.
  • Added [skip ci] rule to the generated commit message which is recommended by semantic-release if running within a CI so you can avoid duplicate builds from change log diffs.
  • Remote pipeline is incrementally more in common with local dev environment.

Follow-up issue

NA

Signed-off-by: Frank Flitton <fflitton@gmail.com>
@FrankFlitton FrankFlitton marked this pull request as ready for review August 1, 2023 23:17
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #810 (6323177) into master (58d5d1a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files         527      527           
  Lines       13362    13362           
  Branches     2540     2540           
=======================================
  Hits         8468     8468           
  Misses       4894     4894           

@ursucarina ursucarina merged commit 7202fb8 into master Aug 2, 2023
11 checks passed
@ursucarina ursucarina deleted the frank/fix-release-commit-message branch August 2, 2023 04:00
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants