Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flyte decks height #813

Merged
merged 4 commits into from
Aug 9, 2023
Merged

fix: flyte decks height #813

merged 4 commits into from
Aug 9, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

Fix flyte deck height

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Updated iframe height and width

Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina requested review from a team, FrankFlitton, jsonporter and 4nalog and removed request for a team August 9, 2023 01:32
@ursucarina ursucarina enabled auto-merge (squash) August 9, 2023 01:35
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #813 (170af69) into master (662429c) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   63.39%   63.39%   -0.01%     
==========================================
  Files         527      527              
  Lines       13390    13391       +1     
  Branches     2548     2548              
==========================================
  Hits         8489     8489              
- Misses       4901     4902       +1     
Files Changed Coverage Δ
.../Executions/ExecutionDetails/ExecutionNodeDeck.tsx 62.50% <66.66%> (-8.93%) ⬇️
...tions/ExecutionDetails/ExecutionDetailsActions.tsx 24.00% <100.00%> (ø)
...components/Launch/LaunchForm/inputHelpers/union.ts 48.43% <100.00%> (ø)

Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina merged commit 184cd75 into master Aug 9, 2023
10 of 11 checks passed
@ursucarina ursucarina deleted the carina/deck branch August 9, 2023 16:42
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants