Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: breadcrumb dropdown render #815

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Conversation

FrankFlitton
Copy link
Contributor

TL;DR

Case for hiding dropdown button conflicted with minified build code.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

fixes flyteorg/flyte#3974

Follow-up issue

NA

Signed-off-by: Frank Flitton <fflitton@gmail.com>
Signed-off-by: Frank Flitton <fflitton@gmail.com>
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #815 (114b62f) into master (4134706) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

❗ Current head 114b62f differs from pull request most recent head 5f726ad. Consider uploading reports for the commit 5f726ad to get more accurate results

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   63.37%   63.36%   -0.02%     
==========================================
  Files         527      527              
  Lines       13394    13396       +2     
  Branches     2548     2550       +2     
==========================================
- Hits         8489     8488       -1     
- Misses       4905     4908       +3     
Files Changed Coverage Δ
...s/Breadcrumbs/components/BreadcrumbFormControl.tsx 13.09% <0.00%> (-1.03%) ⬇️
...nsole/src/components/Breadcrumbs/registry/utils.ts 100.00% <ø> (ø)
...nents/Breadcrumbs/components/BreadcrumbPopover.tsx 10.30% <20.00%> (+0.63%) ⬆️

@FrankFlitton FrankFlitton merged commit a4348d8 into master Aug 19, 2023
6 checks passed
@FrankFlitton FrankFlitton deleted the fix-breadcrumb-dropdown-render branch August 19, 2023 01:46
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ursucarina ursucarina requested review from a team and 4nalog and removed request for a team September 11, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [UI] Breadcrumb dropdowns missing
3 participants