Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional list arg is causing ui launch form to white screen #817

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

fixes launch form crash on collection of ints

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#4033

Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina enabled auto-merge (squash) September 18, 2023 17:04
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 36.36% and project coverage change: -0.02% ⚠️

Comparison is base (a4348d8) 63.36% compared to head (0407cda) 63.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
- Coverage   63.36%   63.34%   -0.02%     
==========================================
  Files         527      527              
  Lines       13396    13401       +5     
  Branches     2550     2555       +5     
==========================================
+ Hits         8488     8489       +1     
- Misses       4908     4912       +4     
Files Changed Coverage Δ
...nents/Launch/LaunchForm/inputHelpers/collection.ts 50.76% <14.28%> (-4.07%) ⬇️
...mponents/Launch/LaunchForm/inputHelpers/integer.ts 92.00% <75.00%> (+0.69%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ursucarina ursucarina requested review from a team, FrankFlitton and jsonporter and removed request for a team September 18, 2023 22:15
@ursucarina ursucarina merged commit 48f006d into master Sep 19, 2023
9 of 11 checks passed
@ursucarina ursucarina deleted the carina/intlist branch September 19, 2023 17:24
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants