Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve security measures in SVG elements #852

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

jasonlai1218
Copy link
Contributor

@jasonlai1218 jasonlai1218 commented Mar 16, 2024

TL;DR

  • Add allow="clipboard-write" attribute to the SVG element

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

In order to implement the copy function on the iframe, the iframe needs to add attributes.
For the reasons, please refer to: flyteorg/flytekit#2264 (review)

Tracking Issue

NA

Follow-up issue

flyteorg/flytekit#2264

- Add `allow="clipboard-write"` attribute to the SVG element

Signed-off-by: jason.lai <jasonlai1218@gmail.com>
Copy link

welcome bot commented Mar 16, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.30%. Comparing base (7aabb32) to head (e61197a).

❗ Current head e61197a differs from pull request most recent head 88778e2. Consider uploading reports for the commit 88778e2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
+ Coverage   54.76%   55.30%   +0.53%     
==========================================
  Files         578      564      -14     
  Lines       15137    14620     -517     
  Branches     2760     2668      -92     
==========================================
- Hits         8290     8085     -205     
+ Misses       6847     6535     -312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsonporter jsonporter merged commit 34edde1 into flyteorg:master Apr 2, 2024
7 checks passed
Copy link

welcome bot commented Apr 2, 2024

Congrats on merging your first pull request! 🎉

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants