Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refresh auth on 401, better error messaging #874

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

ursucarina
Copy link
Contributor

TL;DR

  • Update axios
  • Attempt to refresh auth token in the background when encountering 401's
  • Better error messaging
image

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 25.64103% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 54.57%. Comparing base (bb1db21) to head (c756ceb).

Files Patch % Lines
packages/oss-console/src/App/ApplicationRouter.tsx 0.00% 21 Missing ⚠️
...-console/src/components/data/loadChunkWithAuth.tsx 0.00% 18 Missing ⚠️
...es/oss-console/src/components/data/axiosClient.tsx 31.81% 15 Missing ⚠️
...oss-console/src/components/Errors/ErrorHandler.tsx 44.00% 14 Missing ⚠️
...oss-console/src/components/Errors/GenericError.tsx 42.10% 11 Missing ⚠️
...ss-console/src/components/common/ErrorBoundary.tsx 28.57% 5 Missing ⚠️
...s-console/src/components/data/globalQueryClient.ts 0.00% 2 Missing ⚠️
packages/oss-console/src/App/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   54.74%   54.57%   -0.18%     
==========================================
  Files         578      583       +5     
  Lines       15149    15246      +97     
  Branches     2764     2783      +19     
==========================================
+ Hits         8293     8320      +27     
- Misses       6856     6926      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ursucarina ursucarina enabled auto-merge (squash) May 20, 2024 18:26
@ursucarina ursucarina merged commit c636bf0 into master May 20, 2024
10 of 12 checks passed
@ursucarina ursucarina deleted the carina/refresh branch May 20, 2024 18:47
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.12.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants