From d53d5a64534602efcac60619c209404eeedbbb66 Mon Sep 17 00:00:00 2001 From: 4nalog <4nalog@protonmail.com> Date: Sat, 4 Mar 2023 02:27:53 +0530 Subject: [PATCH 1/3] fix: project settings dashbboard tests Signed-off-by: 4nalog <4nalog@protonmail.com> --- .../Project/test/ProjectDashboard.test.tsx | 31 +++++++++++-------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/packages/console/src/components/Project/test/ProjectDashboard.test.tsx b/packages/console/src/components/Project/test/ProjectDashboard.test.tsx index ecc9c299f..b0d8e0b75 100644 --- a/packages/console/src/components/Project/test/ProjectDashboard.test.tsx +++ b/packages/console/src/components/Project/test/ProjectDashboard.test.tsx @@ -26,6 +26,7 @@ import { } from 'models/Project/api'; import { Admin } from '@flyteorg/flyteidl-types'; import * as LocalCache from 'basics/LocalCache'; +import { LocalCacheProvider } from 'basics/LocalCache/ContextProvider'; import { ProjectDashboard } from '../ProjectDashboard'; import { failedToLoadExecutionsString } from '../constants'; @@ -141,25 +142,29 @@ describe('ProjectDashboard', () => { render( - + + + , ); - it('should display domain attributes section when config was provided', async () => { + it.only('should display domain attributes section when config was provided', async () => { const { getByText } = renderView(); - expect(getProjectAttributes).toHaveBeenCalled(); expect(getProjectDomainAttributes).toHaveBeenCalled(); - await waitFor(() => { - expect(getByText('Domain Settings')).toBeInTheDocument(); - expect( - getByText('cliOutputLocationPrefixFromProjectAttributes'), - ).toBeInTheDocument(); - expect(getByText('cliAnnotationKey')).toBeInTheDocument(); - expect( - getByText('cliAnnotationValueFromProjectAttributes'), - ).not.toBeInTheDocument(); - }); + await waitFor(() => {}); + expect(getProjectAttributes).toHaveBeenCalled(); + + await waitFor(() => {}); + expect(getByText('Domain Settings')).toBeInTheDocument(); + + expect( + getByText('cliOutputLocationPrefixFromProjectAttributes'), + ).toBeInTheDocument(); + expect(getByText('cliAnnotationKey')).toBeInTheDocument(); }); it('should show loading spinner', async () => { From f61590b3d25faf13b6ad180606553b3bb815c00a Mon Sep 17 00:00:00 2001 From: 4nalog <4nalog@protonmail.com> Date: Sat, 4 Mar 2023 02:32:09 +0530 Subject: [PATCH 2/3] chore: remove .only Signed-off-by: 4nalog <4nalog@protonmail.com> --- .../src/components/Project/test/ProjectDashboard.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/console/src/components/Project/test/ProjectDashboard.test.tsx b/packages/console/src/components/Project/test/ProjectDashboard.test.tsx index b0d8e0b75..f30a61dbf 100644 --- a/packages/console/src/components/Project/test/ProjectDashboard.test.tsx +++ b/packages/console/src/components/Project/test/ProjectDashboard.test.tsx @@ -152,7 +152,7 @@ describe('ProjectDashboard', () => { , ); - it.only('should display domain attributes section when config was provided', async () => { + it('should display domain attributes section when config was provided', async () => { const { getByText } = renderView(); expect(getProjectDomainAttributes).toHaveBeenCalled(); await waitFor(() => {}); From 1a25827d941794cff6e4411c705e3b1ce7d78f7d Mon Sep 17 00:00:00 2001 From: 4nalog <4nalog@protonmail.com> Date: Sat, 4 Mar 2023 02:35:10 +0530 Subject: [PATCH 3/3] refactor: remove empty waitFor Signed-off-by: 4nalog <4nalog@protonmail.com> --- .../components/Project/test/ProjectDashboard.test.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/console/src/components/Project/test/ProjectDashboard.test.tsx b/packages/console/src/components/Project/test/ProjectDashboard.test.tsx index f30a61dbf..592b104e7 100644 --- a/packages/console/src/components/Project/test/ProjectDashboard.test.tsx +++ b/packages/console/src/components/Project/test/ProjectDashboard.test.tsx @@ -155,11 +155,13 @@ describe('ProjectDashboard', () => { it('should display domain attributes section when config was provided', async () => { const { getByText } = renderView(); expect(getProjectDomainAttributes).toHaveBeenCalled(); - await waitFor(() => {}); - expect(getProjectAttributes).toHaveBeenCalled(); + await waitFor(() => { + expect(getProjectAttributes).toHaveBeenCalled(); + }); - await waitFor(() => {}); - expect(getByText('Domain Settings')).toBeInTheDocument(); + await waitFor(() => { + expect(getByText('Domain Settings')).toBeInTheDocument(); + }); expect( getByText('cliOutputLocationPrefixFromProjectAttributes'),