From bf750f3843728c72c9ddc56f5f7eac4e6545dbce Mon Sep 17 00:00:00 2001 From: Yuvraj Date: Thu, 1 Jul 2021 18:51:47 +0530 Subject: [PATCH] docs fix Signed-off-by: Yuvraj --- cmd/register/files.go | 2 +- cmd/register/register_util_test.go | 17 ----------------- 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/cmd/register/files.go b/cmd/register/files.go index 877e3870..d758adce 100644 --- a/cmd/register/files.go +++ b/cmd/register/files.go @@ -31,7 +31,7 @@ SourceUploadPath is an optional flag. By default, flytectl will create SourceUpl In case of fast registration, If the SourceUploadPath flag is defined then In this case flytectl will not use the default directory for uploading the source code, it will override the destination path on the registration :: - bin/flytectl register file _pb_output/* -d development -p flytesnacks -v v2 --additionalDistributionPath="s3://dummy/fast" + bin/flytectl register file _pb_output/* -d development -p flytesnacks -v v2 --SourceUploadPath="s3://dummy/fast" Using archive file.Currently supported are .tgz and .tar extension files and can be local or remote file served through http/https. Use --archive flag. diff --git a/cmd/register/register_util_test.go b/cmd/register/register_util_test.go index 461e443b..b4b11563 100644 --- a/cmd/register/register_util_test.go +++ b/cmd/register/register_util_test.go @@ -313,11 +313,6 @@ func TestFlyteManifest(t *testing.T) { assert.NotEmpty(t, tag) } -//func TestGetAdditionalDistributionLoc(t *testing.T) { -// remoteLocation := getRemoteStoragePath("s3://dummy", "test.tar.gz", "v1") -// assert.Equal(t, "s3://dummy/v1-test.tar.gz", string(remoteLocation)) -//} - func TestUploadFastRegisterArtifact(t *testing.T) { t.Run("Successful upload", func(t *testing.T) { testScope := promutils.NewTestScope() @@ -409,15 +404,3 @@ func TestHydrateNode(t *testing.T) { assert.NotNil(t, err) }) } - -// -//func TestGetAdditionalDistributionPath(t *testing.T) { -// t.Run("s3 config validate", func(t *testing.T) { -// ClientDataStore = nil -// s, err := getRemoteStoragePath(context.Background(),ClientDataStore, &storage.Config{ -// InitContainer: "s3-bucket", -// Type: "s3", -// }) -// assert.Equal(t, "s3://s3-bucket/fast",Client, ) -// }) -//}