From 9ee63d4fb8691028cfbecedc355af68da54dbafb Mon Sep 17 00:00:00 2001 From: Yee Hing Tong Date: Tue, 24 Jan 2023 11:18:57 -0800 Subject: [PATCH] wrapping flyte entity in a task node in call to flyte node constructor, not sure if integration tests are actually running Signed-off-by: Yee Hing Tong --- flytekit/remote/remote.py | 4 ++-- tests/flytekit/integration/remote/test_remote.py | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/flytekit/remote/remote.py b/flytekit/remote/remote.py index d8263a8812..0a82d1fb65 100644 --- a/flytekit/remote/remote.py +++ b/flytekit/remote/remote.py @@ -55,7 +55,7 @@ NotificationList, WorkflowExecutionGetDataResponse, ) -from flytekit.remote.entities import FlyteLaunchPlan, FlyteNode, FlyteTask, FlyteWorkflow +from flytekit.remote.entities import FlyteLaunchPlan, FlyteNode, FlyteTask, FlyteTaskNode, FlyteWorkflow from flytekit.remote.executions import FlyteNodeExecution, FlyteTaskExecution, FlyteWorkflowExecution from flytekit.remote.interface import TypedInterface from flytekit.remote.lazy_entity import LazyEntity @@ -1460,7 +1460,7 @@ def sync_execution( upstream_nodes=[], bindings=[], metadata=NodeMetadata(name=""), - flyte_task=flyte_entity, + task_node=FlyteTaskNode(flyte_entity), ) } if len(task_node_exec) >= 1 diff --git a/tests/flytekit/integration/remote/test_remote.py b/tests/flytekit/integration/remote/test_remote.py index dd021eb3be..09b794775b 100644 --- a/tests/flytekit/integration/remote/test_remote.py +++ b/tests/flytekit/integration/remote/test_remote.py @@ -221,6 +221,7 @@ def test_fetch_execute_task_convert_dict(flyteclient, flyte_workflows_register): flyte_task = remote.fetch_task(name="workflows.basic.dict_str_wf.convert_to_string", version=f"v{VERSION}") d: typing.Dict[str, str] = {"key1": "value1", "key2": "value2"} execution = remote.execute(flyte_task, {"d": d}, wait=True) + remote.sync_execution(execution, sync_nodes=True) assert json.loads(execution.outputs["o0"]) == {"key1": "value1", "key2": "value2"}