Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default execution name should be generated in flyteadmin #2678

Merged

Conversation

wayner0628
Copy link
Contributor

@wayner0628 wayner0628 commented Aug 12, 2024

Tracking issue

Why are the changes needed?

  • When user didn't specify execution prefix or name, flytekit should not generate execution name, but send an empty string and let flyteadmin generate

What changes were proposed in this pull request?

  • When nothing is specified, set execution_name to an empty string, see the implementation here

How was this patch tested?

unit testing

Setup process

pytest ./tests/flytekit/unit/remote/test_remote.py

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flyte#5637

Docs link

Signed-off-by: wayner0628 <a901639@gmail.com>
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.21%. Comparing base (69445ff) to head (9915cd3).
Report is 19 commits behind head on master.

Files Patch % Lines
flytekit/remote/remote.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (69445ff) and HEAD (9915cd3). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (69445ff) HEAD (9915cd3)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2678       +/-   ##
===========================================
- Coverage   79.24%   46.21%   -33.03%     
===========================================
  Files         196      187        -9     
  Lines       19785    19196      -589     
  Branches     4008     2774     -1234     
===========================================
- Hits        15678     8871     -6807     
- Misses       3407     9888     +6481     
+ Partials      700      437      -263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com>
flytekit/remote/remote.py Outdated Show resolved Hide resolved
Signed-off-by: wayner0628 <a901639@gmail.com>
@wayner0628 wayner0628 changed the title Send empty execution name to flyteadmin Default execution name should be generated in flyteadmin Aug 13, 2024
flytekit/remote/remote.py Outdated Show resolved Hide resolved
flytekit/remote/remote.py Show resolved Hide resolved
wayner0628 and others added 8 commits August 22, 2024 15:52
Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw enabled auto-merge (squash) August 25, 2024 08:43
@pingsutw pingsutw merged commit 54f0a46 into flyteorg:master Aug 25, 2024
98 of 99 checks passed
@wayner0628 wayner0628 deleted the refactor-send-empty-execution-name branch August 31, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants