Better error message for FailureNodeInputMismatch error

[pingsutw]

Tracking issue

NA

Why are the changes needed?

The error message is not clear enough.

 /Users/kevin/git/flytekit/flytekit/core/promise.py:1213 in flyte_entity_call_handler             │
│                                                                                                  │
│   1210 │   # Make sure arguments are part of interface                                           │
│   1211 │   for k, v in kwargs.items():                                                           │
│   1212 │   │   if k not in entity.python_interface.inputs:                                       │
│ ❱ 1213 │   │   │   raise AssertionError(f"Received unexpected keyword argument '{k}' in functio  │
│   1214 │                                                                                         │
│   1215 │   # Check if we have more arguments than expected                                       │
│   1216 │   if len(args) > len(entity.python_interface.inputs):                                   │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
AssertionError: Error encountered while executing 't2':
  Received unexpected keyword argument 'b' in function 'failure_node_mismatch_interface.t2'

What changes were proposed in this pull request?

Add a new exception (FlyteFailureNodeInputMismatchException) with a clear error message for this exception.
Use it when the failure node's interface doesn't match the workflow interface.

How was this patch tested?

pyflyte -vv run --remote flyte-example/improve_error/failure_node_mismatch_interface.py

Setup process

from click.testing import CliRunner

from flytekit import task, workflow, ImageSpec
from flytekit.clis.sdk_in_container import pyflyte

default = ["pandas", "mypy"]

image = ImageSpec(registry="pingsutw", packages=[*default])


@task(container_image=image)
def t1() -> int:
    return 3 + 2


@task(container_image=image)
def t2(a: int) -> int:
    return a + 3


@workflow(on_failure=t2)
def wf(a: int = 3, b: str = "hello"):
    t1()
    t2(a=a)

Screenshots

Before:

After:

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

NA

Docs link

NA

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.60%. Comparing base (a8f68d7) to head (5ca2b60).
Report is 3 commits behind head on master.

Files	Patch %	Lines
flytekit/core/workflow.py	72.72%	1 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (a8f68d7) and HEAD (5ca2b60). Click for more details.

HEAD has 31 uploads less than BASE

Flag	BASE (a8f68d7)	HEAD (5ca2b60)
	32	1

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
- Coverage   78.91%   71.60%   -7.31%     
==========================================
  Files         316      187     -129     
  Lines       24965    19196    -5769     
  Branches     4012     2773    -1239     
==========================================
- Hits        19702    13746    -5956     
- Misses       4548     4773     +225     
+ Partials      715      677      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.