Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Catch unsupported node types in map node array task #2699

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix: Catch unsupported node types in map node array task #2699

merged 1 commit into from
Aug 21, 2024

Conversation

fg91
Copy link
Member

@fg91 fg91 commented Aug 21, 2024 •
edited
Loading

Why are the changes needed?

Map node array tasks allow mapping a @task over a list of inputs. They do not support @dynamic or @eager tasks though.

However, using unsupported task types is not being caught during registration.

What changes were proposed in this pull request?

  • Detect when a user tries to map an @eager or @dynamic task

How was this patch tested?

  • Add a unit test that would have caught this bug
  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Fix: Catch unsupported node types in map node array task
4c9e86c 
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
wild-endeavor
wild-endeavor approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fg91 fg91 merged commit e28c8bf into master Aug 21, 2024
93 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor wild-endeavor approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario is a code owner

@pingsutw pingsutw Awaiting requested review from pingsutw pingsutw is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla is a code owner

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan thomasjpfan is a code owner

@Future-Outlier Future-Outlier Awaiting requested review from Future-Outlier Future-Outlier is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fg91 @wild-endeavor