test: use constant for stronger tests

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
flyve-mdm · Mar 23, 2018 · 6dd19e8 · 6dd19e8
1 parent f233c89
commit 6dd19e8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/tests/suite-integration/PluginFlyvemdmFleet.php b/tests/suite-integration/PluginFlyvemdmFleet.php
@@ -36,11 +36,6 @@
 
 class PluginFlyvemdmFleet extends CommonTestCase {
 
-   /**
-    * @var string
-    */
-   private $minAndroidVersion = '2.0.0';
-
    public function beforeTestMethod($method) {
       parent::beforeTestMethod($method);
       $this->setupGLPIFramework();
@@ -95,7 +90,7 @@ public function testAddAgentToFleet() {
             'csr'               => '',
             'firstname'         => 'John',
             'lastname'          => 'Doe',
-            'version'           => $this->minAndroidVersion,
+            'version'           => \PluginFlyvemdmAgent::MINIMUM_ANDROID_VERSION . '.0',
             'type'              => 'android',
             'inventory'         => TestingCommonTools::AgentXmlInventory($serial),
          ]

diff --git a/tests/suite-integration/PluginFlyvemdmTask.php b/tests/suite-integration/PluginFlyvemdmTask.php
@@ -36,8 +36,6 @@
 
 class PluginFlyvemdmTask extends CommonTestCase {
 
-   private $minAndroidVersion = '2.0.0';
-
    public function beforeTestMethod($method) {
       parent::beforeTestMethod($method);
       $this->setupGLPIFramework();
@@ -69,7 +67,7 @@ public function testApplyPolicy() {
             'csr'               => '',
             'firstname'         => 'John',
             'lastname'          => 'Doe',
-            'version'           => $this->minAndroidVersion,
+            'version'           => \PluginFlyvemdmAgent::MINIMUM_ANDROID_VERSION . '.0',
             'type'              => 'android',
             'inventory'         => TestingCommonTools::AgentXmlInventory($serial),
          ]