This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 79
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(policy): update code for remove applications
Signed-off-by: Domingo Oropeza <doropeza@teclib.com>
- Loading branch information
Showing
4 changed files
with
287 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
233 changes: 233 additions & 0 deletions
233
tests/suite-unit/PluginFlyvemdmPolicyRemoveapplication.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,233 @@ | ||
| <?php | ||
| /** | ||
| * LICENSE | ||
| * | ||
| * Copyright © 2016-2018 Teclib' | ||
| * Copyright © 2010-2018 by the FusionInventory Development Team. | ||
| * | ||
| * This file is part of Flyve MDM Plugin for GLPI. | ||
| * | ||
| * Flyve MDM Plugin for GLPI is a subproject of Flyve MDM. Flyve MDM is a mobile | ||
| * device management software. | ||
| * | ||
| * Flyve MDM Plugin for GLPI is free software: you can redistribute it and/or | ||
| * modify it under the terms of the GNU Affero General Public License as published | ||
| * by the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * Flyve MDM Plugin for GLPI is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with Flyve MDM Plugin for GLPI. If not, see http://www.gnu.org/licenses/. | ||
| * ------------------------------------------------------------------------------ | ||
| * @author Domingo Oropeza | ||
| * @copyright Copyright © 2018 Teclib | ||
| * @license AGPLv3+ http://www.gnu.org/licenses/agpl.txt | ||
| * @link https://github.com/flyve-mdm/glpi-plugin | ||
| * @link https://flyve-mdm.com/ | ||
| * ------------------------------------------------------------------------------ | ||
| */ | ||
|
|
||
| namespace tests\units; | ||
|
|
||
| use Glpi\Test\CommonTestCase; | ||
|
|
||
| class PluginFlyvemdmPolicyRemoveapplication extends CommonTestCase { | ||
|
|
||
| private $dataField = [ | ||
| 'group' => 'application', | ||
| 'symbol' => 'removeApp', | ||
| 'type_data' => '', | ||
| 'unicity' => 0, | ||
| ]; | ||
|
|
||
| private $packageName = 'com.domain.author.application.apk'; | ||
| private $filename = 'application.apk'; | ||
|
|
||
| /** | ||
| * @param null|\PluginFlyvemdmPolicy $policyData | ||
| * @return array | ||
| */ | ||
| private function createNewPolicyInstance($policyData = null) { | ||
| if(null === $policyData){ | ||
| $policyData = new \PluginFlyvemdmPolicy(); | ||
| $policyData->fields = $this->dataField; | ||
| } | ||
| $policy = $this->newTestedInstance($policyData); | ||
| return [$policy, $policyData]; | ||
| } | ||
|
|
||
| /** | ||
| * @return array | ||
| */ | ||
| protected function validationProvider() { | ||
| return [ | ||
| 'Check ID exist' => [ | ||
| 'data' => ['', '', 0], | ||
| 'expected' => [false, 'An application ID is required'], | ||
| ], | ||
| 'Check itemtype is empty 1' => [ | ||
| 'data' => ['lorem', 'Bad Value', 0], | ||
| 'expected' => [false], | ||
| ], | ||
| 'Check itemtype is empty 2' => [ | ||
| 'data' => ['lorem', '', 1], | ||
| 'expected' => [false], | ||
| ], | ||
| 'Valid check 1' => [ | ||
| 'data' => ['any value', '', 0], | ||
| 'expected' => [true], | ||
| ], | ||
| ]; | ||
| } | ||
|
|
||
| /** | ||
| * @dataProvider validationProvider | ||
| * @tags testIntegrityCheck | ||
| * @param array $data | ||
| * @param array $expected | ||
| */ | ||
| public function testIntegrityCheck(array $data, array $expected) { | ||
| list($policy) = $this->createNewPolicyInstance(); | ||
| $success = $policy->integrityCheck($data[0], $data[1], $data[2]); | ||
| $this->boolean($success)->isEqualTo($expected[0]); | ||
| if (!$expected[0] && isset($expected[1])) { | ||
| $this->string($_SESSION["MESSAGE_AFTER_REDIRECT"][0][0])->isEqualTo($expected[1]); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @return array | ||
| */ | ||
| public function unicityCheckProvider() { | ||
| return [ | ||
| 'Check for invalid package' => [ | ||
| 'data' => ['package_name', 'id'], | ||
| 'expected' => [true], | ||
| ], | ||
| // TODO: For test this case a fleet must be created first | ||
| /*'Check for valid package' => [ | ||
| 'data' => ['package_name', 'id'], | ||
| 'expected' => [false], | ||
| ],*/ | ||
| ]; | ||
| } | ||
|
|
||
| /** | ||
| * @dataProvider unicityCheckProvider | ||
| * @tags testUnicityCheck | ||
| * @param array $data | ||
| * @param array $expected | ||
| */ | ||
| public function testUnicityCheck(array $data, array $expected) { | ||
| list($policy) = $this->createNewPolicyInstance(); | ||
| $mockInstance = $this->newMockInstance('\PluginFlyvemdmFleet'); | ||
| $mockInstance->getMockController()->getID = 1; | ||
| if(!$expected[0]){ | ||
| $application = $this->createAppInDB(); | ||
| $data[0] = $application->getName(); | ||
| $data[1] = $application->getID(); | ||
| } | ||
| $this->boolean($policy->unicityCheck($data[0], \PluginFlyvemdmPackage::class, $data[1], | ||
| $mockInstance))->isEqualTo($expected[0]); | ||
| } | ||
|
|
||
| /** | ||
| * @return array | ||
| */ | ||
| public function applyProvider() { | ||
| $package = $this->createAppInDB(); | ||
| return [ | ||
| 'Check for invalid arguments 1' => [ | ||
| 'data' => [null, null, null], | ||
| 'expected' => ['return' => false], | ||
| ], | ||
| 'Check for invalid arguments 2' => [ | ||
| 'data' => [null, null, ''], | ||
| 'expected' => ['return' => false, 'message'=>'An application ID is required'], | ||
| ], | ||
| 'Check for invalid arguments 3' => [ | ||
| 'data' => [null, null, -10], | ||
| 'expected' => ['return' => false, 'message'=>'The application does not exists'], | ||
| ], | ||
| 'Check for correct value' => [ | ||
| 'data' => [null, $package, $package->getID()], | ||
| 'expected' => ['return' => true], | ||
| ], | ||
| ]; | ||
| } | ||
|
|
||
| /** | ||
| * @dataProvider applyProvider | ||
| * @tags testApply | ||
| * @param array $data | ||
| * @param array $expected | ||
| */ | ||
| public function testApply(array $data, array $expected) { | ||
| $policyData = null; | ||
| if (true === $expected['return']) { | ||
| $policyData = new \PluginFlyvemdmPolicy(); | ||
| $policyData->getFromDBBySymbol('removeApp'); | ||
| } | ||
| list($policy) = $this->createNewPolicyInstance($policyData); | ||
| $mockInstance = $this->newMockInstance('\PluginFlyvemdmFleet'); | ||
| $mockInstance->getMockController()->getID = 1; | ||
| $result = $policy->apply($mockInstance, $data[0], $data[1], $data[2]); | ||
| $this->boolean($result)->isEqualTo($expected['return']); | ||
| if (!$expected['return'] && isset($expected['message'])) { | ||
| $this->string($_SESSION["MESSAGE_AFTER_REDIRECT"][1][0])->isEqualTo($expected['message']); | ||
| unset($_SESSION["MESSAGE_AFTER_REDIRECT"]); // to clear the buffer | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @tags testGetMqttMessage | ||
| */ | ||
| public function testGetMqttMessage() { | ||
| list($policy) = $this->createNewPolicyInstance(); | ||
| $this->boolean($policy->getMqttMessage(null, null, null))->isFalse(); | ||
| $item = $this->createAppInDB(); | ||
| $packageName = $item->getField('package_name'); | ||
| $result = $policy->getMqttMessage($packageName, '', 0); | ||
| $this->array($result)->hasKeys(['id', $this->dataField['symbol']]) | ||
| ->string($result['id'])->isEqualTo($item->getID()) | ||
| ->string($result[$this->dataField['symbol']])->isEqualTo($packageName); | ||
| } | ||
|
|
||
| /** | ||
| * Create an application (directly in DB) because we are not uploading any file | ||
| * @return \PluginFlyvemdmPackage | ||
| */ | ||
| private function createAppInDB() { | ||
| global $DB; | ||
|
|
||
| $uniqid = uniqid(); | ||
| $table_file = \PluginFlyvemdmPackage::getTable(); | ||
| $query = "INSERT INTO `$table_file` ( | ||
| `package_name`, | ||
| `alias`, | ||
| `version`, | ||
| `filename`, | ||
| `entities_id`, | ||
| `dl_filename`, | ||
| `icon` | ||
| ) VALUES ( | ||
| '" . $uniqid . $this->packageName . "', | ||
| 'application', | ||
| '1.0.5', | ||
| '0/" . $uniqid . $this->filename . "', | ||
| '0', | ||
| '" . $this->filename . "', | ||
| '' | ||
| )"; | ||
| $result = $DB->query($query); | ||
| $this->boolean($result)->isTrue(); | ||
|
|
||
| $file = new \PluginFlyvemdmPackage(); | ||
| $file->getFromDB($DB->insert_id()); | ||
| $this->boolean($file->isNewItem())->isFalse(); | ||
|
|
||
| return $file; | ||
| } | ||
| } |