fix(agent): fixed agent account name on enrollment process.

inc/agent.class.php

@@ -1116,7 +1116,8 @@ protected function enrollByInvitationToken($input) {
       $agentAccount = new User();
       $agentAccount->add([
          'usercategories_id' => $config['agentusercategories_id'],
-         'name'              => $serial,
+         'name'              => 'flyvemdm-' . PluginFlyvemdmCommon::generateUUID(),
+         'realname'          => $serial,
          '_profiles_id'      => $config['agent_profiles_id'],
          'profiles_id'       => $config['agent_profiles_id'],      // Default profile when user logs in
          '_entities_id'      => $entityId,

inc/common.class.php

@@ -91,4 +91,29 @@ static function getEnumValues($table, $field) {
       return $enum;
    }
 
+   /**
+    * @return string pseudo-random UUID version 4
+    */
+   public static function generateUUID() {
+      return sprintf('%04x%04x-%04x-%04x-%04x-%04x%04x%04x',
+
+         // 32 bits for "time_low"
+         mt_rand(0, 0xffff), mt_rand(0, 0xffff),
+
+         // 16 bits for "time_mid"
+         mt_rand(0, 0xffff),
+
+         // 16 bits for "time_hi_and_version",
+         // four most significant bits holds version number 4
+         mt_rand(0, 0x0fff) | 0x4000,
+
+         // 16 bits, 8 bits for "clk_seq_hi_res",
+         // 8 bits for "clk_seq_low",
+         // two most significant bits holds zero and one for variant DCE1.1
+         mt_rand(0, 0x3fff) | 0x8000,
+
+         // 48 bits for "node"
+         mt_rand(0, 0xffff), mt_rand(0, 0xffff), mt_rand(0, 0xffff)
+      );
+   }
 }

tests/suite-integration/PluginFlyvemdmAgent.php

@@ -191,7 +191,7 @@ public function testEnrollAgent() {
 
       // Test a new user for the agent exists
       $agentUser = new \User();
-      $agentUser->getFromDBbyName($serial);
+      $agentUser->getFromDBByCrit(['realname' => $serial]);
       $this->boolean($agentUser->isNewItem())->isFalse();
 
       // Test the agent user does not have a password