This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
Defer apk parse #127
Merged
Defer apk parse #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btry
force-pushed
the
feature/defer_apk_parse
branch
from
213337e to
8692732
Compare
btry
commented
Sep 28, 2017
inc/package.class.php
Outdated
|
|
||
| switch ($name) { | ||
| case 'ParseApplication' : | ||
| return array('description' => __('Parse an application to find metadata')); |
There was a problem hiding this comment.
domain of translation missing
btry
force-pushed
the
feature/defer_apk_parse
branch
from
8692732 to
8c48e51
Compare
btry
force-pushed
the
feature/defer_apk_parse
branch
from
8c48e51 to
34a3738
Compare
|
Hi, @btry Can I squash and merge this PR? |
|
Yes, it seems to work perfectly as far as I tested it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs an extra review to not introduce bug