Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecation codes #91

Open
omid opened this issue Apr 5, 2023 · 0 comments
Open

Remove the deprecation codes #91

omid opened this issue Apr 5, 2023 · 0 comments

Comments

@omid
Copy link
Collaborator

omid commented Apr 5, 2023

After updating chrono-tz we see some deprecated APIs.
chrono itself is still using the deprecated API, we can also wait till they fix it.

For example, here is one of our deprecated impls:
Screenshot from 2023-03-25 08-55-02

Now when I go to chrono's Local impl, you see they use a deprecated method also (My IDE didn't mark it as deprecared, but it is the one!)
And the whole trait method is also marked as deprecated.
Screenshot from 2023-03-25 08-55-42

AFAICS, this impl TimeZone for we have, is kinda combination of its impl for chrono's Local and chorono-tz's Tz, which you can find them here and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant