Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transformers dependency #11

Open
tdoublep opened this issue Jun 3, 2024 · 0 comments
Open

Remove transformers dependency #11

tdoublep opened this issue Jun 3, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@tdoublep
Copy link
Collaborator

tdoublep commented Jun 3, 2024

We had to add a dependency on transformers in order to perform client-side tokenization when using fmperf with vLLM. Since vLLM recently added support for server-side truncation, this is no longer necessary. We should be able to adapt the load generator to use this new feature, removing that dependency completely.
@tdoublep tdoublep added the good first issue Good for newcomers label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdoublep