Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using fmt::localtime in wide-char format strings is broken #2127

Closed
yNeo opened this issue Feb 4, 2021 · 2 comments
Closed

Using fmt::localtime in wide-char format strings is broken #2127

yNeo opened this issue Feb 4, 2021 · 2 comments
Labels
help wanted

Comments

@yNeo
Copy link
Contributor

yNeo commented Feb 4, 2021

chrono.h:L416 is:
FMT_CONSTEXPR auto parse(format_parse_context& ctx) -> decltype(ctx.begin()) {
while it should be:
FMT_CONSTEXPR auto parse(basic_format_parse_context<Char>& ctx) -> decltype(ctx.begin()) {
@vitaut
Copy link
Contributor

vitaut commented Feb 5, 2021

Could you submit a PR?

@vitaut vitaut closed this as completed Feb 13, 2021
@vitaut
Copy link
Contributor

vitaut commented Feb 13, 2021

Fixed in c5979d5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @yNeo