-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native c++ module support from CMake #3990
Comments
Now that C++20 module support has been released in CMake I think it's reasonable to add it, at least as an option. Thanks for the suggestion. |
@vitaut I have raised a PR for it. Lets see if it is a good start point. |
excuse me, could you help me for an example of import fmt? I have failed for a day.... |
Hi, fmtlib supports using
FMT_MODULE
to make itself a c++ module, but the implementation is building manually rather than using native support from CMake. This leads to some problems. For example, we cannot add definitions likeFMT_STATIC_THOUSANDS_SEPARATOR
.I saw previous discussion #3429 (comment) concerning native support from CMake is not yet ready. But now it has been stabilize: https://www.kitware.com/import-cmake-the-experiment-is-over. Maybe it's time to add the support?
I tried something like
and it does work! (though we cannot add
FMT_STATIC_THOUSANDS_SEPARATOR
unless we comment outchrono.h
.)The text was updated successfully, but these errors were encountered: