From 68785fb8dcb46ba9512a7a9932dd26f6645a743d Mon Sep 17 00:00:00 2001 From: bluoss Date: Tue, 24 Sep 2024 17:35:26 +0200 Subject: [PATCH] fix(slider): correct computing of gapRatio While the distance between two labels is too short for text at every label, we find out if we use only ticks with no text (gapRatio > 1) and apply text at any other tick (gapRatio = 2), any third tick (gapRatio = 3) and so on --- src/definitions/modules/slider.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/definitions/modules/slider.js b/src/definitions/modules/slider.js index 114a83f490..ecc19ffa3d 100644 --- a/src/definitions/modules/slider.js +++ b/src/definitions/modules/slider.js @@ -765,14 +765,12 @@ gapCounter = 1 ; - // While the distance between two labels is too short, - // we divide the number of labels at each iteration - // and apply only if the modulo of the operation is an odd number. + // While the distance between two labels is too short for text at every label, + // we find out if we use only ticks with no text (gapRatio > 1) + // and apply text at any other tick (gapRatio = 2), any third tick (gapRatio = 3) and so on if (trackLength > 0) { while ((trackLength / numLabels) * gapCounter < settings.labelDistance) { - if (!(numLabels % gapCounter)) { - gapRatio = gapCounter; - } + gapRatio = gapCounter; gapCounter += 1; } }