Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #400

Closed
wvengen opened this issue Feb 8, 2016 · 5 comments
Closed

Fix tests #400

wvengen opened this issue Feb 8, 2016 · 5 comments
Labels
Milestone

Comments

@wvengen
Copy link
Member

wvengen commented Feb 8, 2016

After the last bundle update tests are failing.
https://travis-ci.org/foodcoops/foodsoft/builds/106242310

@wvengen wvengen added the bug label Feb 8, 2016
@wvengen wvengen added this to the 4.5 milestone Feb 8, 2016
@wvengen wvengen mentioned this issue Feb 17, 2016
@wvengen
Copy link
Member Author

wvengen commented Feb 18, 2016

huacnlee/rails-settings-cached#73 is the cause of failing config test

@wvengen
Copy link
Member Author

wvengen commented Feb 18, 2016

the other problem was a capybara upgrade, where some buttons fall off the page now and can't be found anymore. Worked around by scrolling the page to the bottom in d6bf09b

@wvengen
Copy link
Member Author

wvengen commented Feb 19, 2016

Still a problem though :(

@wvengen
Copy link
Member Author

wvengen commented Feb 23, 2016

Tests succeed locally, so it's a Travis problem now ...

@wvengen
Copy link
Member Author

wvengen commented Feb 23, 2016

Yay, needed to start a display manager so that the browser window could be maximised. After updates of capybara/selenium/firefox, it seemed that the browser window got a slightly different size, not enough for all tests to have the relevant elements in view.

Fixed by 6d338ff.

@wvengen wvengen closed this as completed Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant