Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Formatting (markdown / html support) #918

Closed
yksflip opened this issue Jan 27, 2022 · 5 comments
Closed

Message Formatting (markdown / html support) #918

yksflip opened this issue Jan 27, 2022 · 5 comments
Labels
Milestone

Comments

@yksflip
Copy link
Member

yksflip commented Jan 27, 2022

Hi!

Is it possible to use markdown or html syntax to format messages in the Foodsoft message system?
Or is there maybe a simple way to add this feature?
Our Members use the foodsoft message system as main communication system and do not find the plaintext messages very clear.

Best regards,
Philipp

@wvengen
Copy link
Member

wvengen commented Jan 31, 2022

Thanks for the suggestion! I agree that the message mails could be a lot more beautiful. Adding formatting options would be nice -
ActionText could make sense here, though we're still on Rails 5, which doesn't include it by default (but I guess it could be added as a gem in the meantime).

In my mind, the first step would be more beautiful mails (html + plain text), for Foodsoft in general, then adding formatting in message composition.

@yksflip
Copy link
Member Author

yksflip commented Feb 10, 2023

I managed to add a richtexteditor to send messages with ActionText with this two commits:

Once we've got the rails upgrade merged I'll open a PR for this!

About the email html template I feel a bit unsure how to do it properly. I tried to do something simple as just making the footer urls tags and it required some changes in the i18n, because urls are passed as arguments. Not sure what's a good way to do this nicely for html and plaintext.

@wvengen
Copy link
Member

wvengen commented Feb 10, 2023

Ah, very nice!

Not sure if current messages can use wiki-syntax, if so:

  • Do we need to do migration from wiki-text to ActionText?
  • Is that still supported? (or are users ok with the change)

Regarding the html/text issue in email: what about extracting text from html and using that as plaintext?

@yksflip
Copy link
Member Author

yksflip commented Feb 20, 2023

There was no formatting options for messages before. But the wiki is a good hint, maybe we could introduce actiontext there in the future as well.
Not sure if I understand you correctly. Converting the message body to plaintext is not the problem. What I was struggling with, was how to reduce duplication for both email views. e.g. for the foodsoft_message.html.haml that renders the message footer, there's now some duplicates in the locales with, and without url parameter. But maybe that's okay for now as it's just that one template., we can dicuss this in the pr once opened. I guess this will be more relevant when adding html templates for all email views.

@yksflip yksflip added this to the 4.8 milestone Jun 10, 2023
@yksflip yksflip moved this to Next Release in Foodsoft roadmap Jun 10, 2023
@yksflip yksflip moved this from Next Release to In Progress in Foodsoft roadmap Jun 21, 2023
@yksflip
Copy link
Member Author

yksflip commented Aug 4, 2023

see #1013

@yksflip yksflip closed this as completed Aug 4, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Foodsoft roadmap Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants