Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruby 2.7 #939

Closed
wvengen opened this issue Apr 10, 2022 · 4 comments
Closed

Upgrade to Ruby 2.7 #939

wvengen opened this issue Apr 10, 2022 · 4 comments
Labels
tech debt technical debt

Comments

@wvengen
Copy link
Member

wvengen commented Apr 10, 2022

With Ruby 2.6 recently gone EOL, we better move to 2.7 (or later).
Did a quick check, using 2.7 doesn't break the specs.

Then do a release, finally!

@wvengen wvengen added the tech debt technical debt label Apr 10, 2022
@wvengen
Copy link
Member Author

wvengen commented Apr 10, 2022

Upgrading to 3.0 is not so easy, unfortunately.
First thing encountered:

Failure/Error: value = RailsSettings::CachedSettings["foodcoop.#{self.scope}.#{key}"]

ArgumentError:
  wrong number of arguments (given 1, expected 0)
# ./lib/foodsoft_config.rb:118:in `[]'
# ./lib/foodsoft_config.rb:81:in `block in init_mailing'
# ./lib/foodsoft_config.rb:80:in `each'
# ./lib/foodsoft_config.rb:80:in `init_mailing'

Probably RailsSettings::CachedSettings needs a change. We need to replace it anyway, because of #867 (e.g. by just loading all settings on each request, or caching each setting in Redis and keeping it updated in FoodsoftConfig).

@kidhab
Copy link
Contributor

kidhab commented Apr 15, 2022

I think upgrading to Ruby 2.7 requires also an upgrade to Rails 6(.1). Regardless Rails 5.2 is only supported until June 2022.

Looking at RailsBump only apivore isn't supported on newer versions any more. All other gems should be fine. Although there's a PR adding Rails 6 compability. Or maybe swith to an alternative like mini-apivore.

@Viehlieb
Copy link
Contributor

Hey folks,
We are currently working on the ruby upgrade and plan to upgrade to 6.1 anyways.
We got some funding for further developing foodsoft. Check out the project website or if you want to get in touch about the upgrade, contact me or the team:

https://prototypefund.de/project/weiterentwicklung-von-foodsoft/

We'll inform you about our process.

For Rails Upgrade we created a separate issue and we are currently working on that.
#956

Best regards

@kidhab
Copy link
Contributor

kidhab commented Jun 9, 2023

done with #979

@kidhab kidhab closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt technical debt
Projects
None yet
Development

No branches or pull requests

3 participants