You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Multiplier default value is 1 at the moment.
When it's 0, index income with a sub element calculation fails. Probably it's mixing MainElement's multiplier with its own element multiplier.
The text was updated successfully, but these errors were encountered:
In elementItem.js, multiplier function, it was mixing no multiplier field and the user has no multiplier value cases.
In case if there is no multiplier field on the element, it should have returned 1 as a default value, in order to make a correct calculation (or it could of course return null and the caller could make a null check and don't try to multiply the value since there is none).
However, if there is a multiplier field on the element but the user didn't set any value to it, then the default value should have been 0.
Since these cases were checked like the same, it was either returning 0 (and resulting in a calculation error) or returning 1, which had no calculation issue but of course wasn't correct since every CMRP was starting with value 1 for 'Number of Sales'.
Multiplier default value is 1 at the moment.
When it's 0, index income with a sub element calculation fails. Probably it's mixing MainElement's multiplier with its own element multiplier.
The text was updated successfully, but these errors were encountered: