Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Certain characters get weird in commit messages. #656

Closed
hrs-o opened this issue Jun 17, 2019 · 2 comments
Closed

[BUG] Certain characters get weird in commit messages. #656

hrs-o opened this issue Jun 17, 2019 · 2 comments
Milestone

Comments

@hrs-o
Copy link

hrs-o commented Jun 17, 2019

Hi, I am using the Japanese.
I noticed that when I do a commit with fork, certain characters don't get as expected.
This is due to the Unicode combining character.

Details are described below, but the problem is "" and "" are not "" as a byte string.
Therefore, the search does not match.

ref:
https://en.wikipedia.org/wiki/Combining_character
http://www.fileformat.info/info/unicode/char/3099/index.htm


I committed on fork and terminal.

  • fork
Author: hrs-o <hrs-o@users.noreply.github.com>
Date:   Mon Jun 17 19:02:22 2019 +0900

    バナー commit by fork
  • terminal
Author: hrs-o <hrs-o@users.noreply.github.com>
Date:   Mon Jun 17 19:02:37 2019 +0900

    バナー commit by terminal

I did git log at terminal and checked the character code of "バナー".

convert site:
https://so-zou.jp/web-app/text/encode-decode/

  • fork
U+E3838F
U+E38299
U+E3838A
U+E383BC
  • terminal
U+E38390
U+E3838A
U+E383BC

U+E3838F is "" of Japanese katakana.
U+E38299 is "" of Japanise voiced sound (dakuon).

ref:
https://en.wiktionary.org/wiki/%E6%BF%81%E9%9F%B3#Japanese

@hrs-o hrs-o changed the title Certain characters get weird in commit messages. [BUG] Certain characters get weird in commit messages. Jun 19, 2019
@hrs-o
Copy link
Author

hrs-o commented Jun 19, 2019

  • OS
    • macOS Mojave 10.14.5
  • Fork
    • Version 1.0.80

@hrs-o
Copy link
Author

hrs-o commented Jun 27, 2019

It seems that it duplicated with #444, so it closes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants