Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea account integration uses wrong URLs #1476

Open
mco-dgmr opened this issue Mar 2, 2022 · 2 comments
Open

Gitea account integration uses wrong URLs #1476

mco-dgmr opened this issue Mar 2, 2022 · 2 comments

Comments

@mco-dgmr
Copy link

mco-dgmr commented Mar 2, 2022

I like the Gitea account integration, but I ran into two problems:

  1. We are using a locally hosted Gitea instance on a non-standard port number. When using the "Create Pull Request on 'origin'" option, the opened URL does not contain the port number, and so the page doesn’t work.
  2. Even if I add the non-standard port number manually, the link doesn’t work, because Gitea also expects the target branch in the compare URL. So Fork currently generates the URL https://scm.example/group/repo/compare/feature%2Fbranch, whereas it should use https://scm.example:5000/group/repo/compare/master...feature%2Fbranch (if the pull request is to be merged into master).

We’re using Gitea 1.16.9, btw.

Originally posted by @mco-dgmr in #1144 (comment)

@TanyaPristupova
Copy link
Collaborator

  1. We are using a locally hosted Gitea instance on a non-standard port number. When using the "Create Pull Request on 'origin'" option, the opened URL does not contain the port number, and so the page doesn’t work.

I confirm that.

  1. Even if I add the non-standard port number manually, the link doesn’t work, because Gitea also expects the target branch in the compare URL.

https://scm.example/group/repo/compare/feature%2Fbranch is legal. This must have been implemented in Gitea 1.16 (go-gitea/gitea#17975) and currently works properly on https://try.gitea.io. For example: https://try.gitea.io/fx6904/gitea/compare/6543-patch-1

@mco-dgmr
Copy link
Author

mco-dgmr commented Mar 3, 2022

Thank you @TanyaPristupova; I’ll see about upgrading our local version of Gitea to fix the second problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants