Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components wrapped inside a fragment do not have Dividers #226

Closed
petewins opened this issue Mar 10, 2024 · 2 comments
Closed

Components wrapped inside a fragment do not have Dividers #226

petewins opened this issue Mar 10, 2024 · 2 comments

Comments

@petewins
Copy link

petewins commented Mar 10, 2024

Describe the bug
Components wrapped inside a fragment do not have Dividers inside a View. Not sure if this is the intended behavior given how the Fragment wrapper is initially counted as one component but I noticed this behavior when I had a Fragment with dynamic number of children

To Reproduce
https://codesandbox.io/p/devbox/reshaped-view-divider-demo-8sprjr?file=%2Fapp%2Fpage.tsx%3A12%2C1

Expected behavior
Expect Children of the View to have dividers, including Child components with fragments

Screenshots
If applicable, add screenshots to help explain your problem.
image
image

Environment (please complete the following information):

  • OS: OSX 14.3.1
  • Browser: Chrome

Additional context
Add any other context about the problem here.

@blvdmitry blvdmitry moved this to 2.11.0 in Reshaped Mar 12, 2024
@blvdmitry blvdmitry moved this from 2.11.0 to In Progress in Reshaped Mar 16, 2024
@blvdmitry
Copy link
Contributor

Should be fixed in 2.10.5

<View direction="row" gap={4} divided>
	<Placeholder>Item 1</Placeholder>
	<>
		<Placeholder>Item 2</Placeholder>
		<Placeholder>Item 3</Placeholder>
	</>
</View>

Image

@github-project-automation github-project-automation bot moved this from In Progress to Waiting for the release in Reshaped Mar 20, 2024
@petewins
Copy link
Author

Thank you 💛

@blvdmitry blvdmitry moved this from Waiting for the release to Recently completed in Reshaped Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently completed
Development

No branches or pull requests

2 participants