Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify JSON contributions dynamically #30

Closed
forman opened this issue Nov 23, 2023 · 1 comment
Closed

Modify JSON contributions dynamically #30

forman opened this issue Nov 23, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@forman
Copy link
Owner

forman commented Nov 23, 2023

Is your feature request related to a problem? Please describe.

In my app, I'm using contribution point menus from the contrib module to let extensions contribute menu items.
Menu items must currently provided by JSON entries in the extension's package.json.
I have a top-level menu "View" with a submenu "Tool Views... >".
This submenu should be filled from the contributions to another contribution point, namely toolViews.
Therefore I need to programmatically add (or replace) JSON entries to (or in) the menus contribution point.

Describe the solution you'd like

Possible options

  • (1) Support an auto-fill marker in the specific submenus contribution point so the framework can generate the menu entries from contributions of another referenced contribution point.
  • (2) Support adding JSON contributions programmatically, e.g., provide a new registerJsonContribution or the like similar to registerCodeContribution .

(1) is more pragmatic and applies to that specific contrib point only
(2) is more generic and flexible

And (2) does not exclude (1).

@forman forman added the enhancement New feature or request label Nov 23, 2023
@forman forman self-assigned this Nov 23, 2023
@forman forman changed the title Add JSON contributions programmatically Modify JSON contributions dynamically Nov 23, 2023
@forman forman added the wontfix This will not be worked on label Nov 27, 2023
@forman
Copy link
Owner Author

forman commented Nov 27, 2023

Decided to let the UI-providing application generate dynamic menus instead of implementing it here.

@forman forman closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant