Fix error in touchmove event #145
Conversation
There was a problem hiding this comment.
Thank you @maurispalletti for the PR. I'd like to take some time and think about this a bit.
I don't quite know if this is a good or bad addtion or even needed.
Mainly since the callback provides the full event now, users could just check for event.cancelable themselves then call preventDefault() when they deem appropriate.
Example PR of this is the upgrade i made for react-image-gallery:
src/__tests__/index.spec.js
Outdated
| @@ -210,16 +211,17 @@ function setupGetMountedComponent(TYPE, mockListeners = mockListenersSetup) { | |||
| it('calls preventDefault when onSwiping is present', () => { | |||
| const onSwiping = jest.fn() | |||
| const preventDefault = jest.fn() | |||
| const cancelable = jest.fn() | |||
There was a problem hiding this comment.
💡 mind updating this and the other test usage to boolean's? const cancelable = true?
https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelable
There was a problem hiding this comment.
Sure, my bad. I'll change it now and update the PR.
|
@hartzis, I haven't found any potential issues. It just helps to avoid that console error. |
|
@maurispalletti I like your thinking! I'm also very comfortable with browser support. Let's merge and publish this. |
Fix issue #128 .
e.cancelable validation added to e.preventDefault(), to avoid console error
Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted..