Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): change form validity when expressionProperty change. #590

Merged
merged 1 commit into from
Dec 8, 2017
Merged

fix(core): change form validity when expressionProperty change. #590

merged 1 commit into from
Dec 8, 2017

Conversation

aitboudad
Copy link
Member

@aitboudad aitboudad commented Dec 8, 2017

What kind of change does this PR introduce? Bug fix
fix #582


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #590 into master will increase coverage by 1.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   92.93%   94.09%   +1.15%     
==========================================
  Files          16       16              
  Lines         736      745       +9     
  Branches      212      215       +3     
==========================================
+ Hits          684      701      +17     
+ Misses         52       44       -8
Impacted Files Coverage Δ
src/core/src/services/formly.form.builder.ts 97.14% <100%> (+0.08%) ⬆️
src/core/src/utils.ts 96.11% <100%> (+0.03%) ⬆️
src/core/src/components/formly.field.ts 92.42% <100%> (+8.7%) ⬆️
src/core/src/services/formly.config.ts 90.9% <0%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a949e...0c4b2ff. Read the comment docs.

@aitboudad aitboudad merged commit 290761c into ngx-formly:master Dec 8, 2017
@aitboudad aitboudad deleted the issue_582 branch December 8, 2017 16:46
aitboudad pushed a commit that referenced this pull request Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ExpressionProperty for required property issue
2 participants