Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): assign correctly model value in field expression during build. #596

Merged
merged 1 commit into from
Dec 10, 2017
Merged

fix(core): assign correctly model value in field expression during build. #596

merged 1 commit into from
Dec 10, 2017

Conversation

aitboudad
Copy link
Member

@aitboudad aitboudad commented Dec 10, 2017

What kind of change does this PR introduce? Bug fix


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #596 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   93.91%   93.89%   -0.02%     
==========================================
  Files          16       16              
  Lines         739      737       -2     
  Branches      214      214              
==========================================
- Hits          694      692       -2     
  Misses         45       45
Impacted Files Coverage Δ
src/core/src/services/formly.form.builder.ts 97.02% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb5159...574484e. Read the comment docs.

@aitboudad aitboudad merged commit 77d62ae into ngx-formly:master Dec 10, 2017
@aitboudad aitboudad deleted the field-expression branch December 10, 2017 13:58
aitboudad pushed a commit that referenced this pull request Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants