-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override message.from via send options #313
Comments
@peterpetre care to submit a pull request + test? |
@niftylettuce #319 is ok? |
Since this would be a breaking change, I think I'll publish with major semver version, agreed? |
@peterpetre I have just merged your work. I updated the README and added a new section here https://github.com/niftylettuce/email-templates#v5-breaking-changes (might need a bit more explaining with an example - if you care to submit a PR to update this README with a code example that shows before/after issue that would be great). email-templates@5.0.0 has been published to NPM. Let me know if you have any issues, and thank you for your contributions to this project 👏 🎉 |
Please allow to pass message.from on send options and this should override the this.config.message.from
The text was updated successfully, but these errors were encountered: