Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guzzle mangles query strings #1079

Closed
jtojnar opened this issue Jan 23, 2019 · 2 comments
Closed

Guzzle mangles query strings #1079

jtojnar opened this issue Jan 23, 2019 · 2 comments
Labels
bug upstream issue
Milestone
2.19

Comments

@jtojnar
Copy link
Member

jtojnar commented Jan 23, 2019

Reported on fora, URLs like https://reprap.org/forum/feed.php?110,replies=1,type=rss are requested as https://reprap.org/forum/feed.php?110%2Creplies%3D1%2Ctype%3Drss:

<?php
$httpClient = new GuzzleHttp\Client;
echo $httpClient->get('https://reprap.org/forum/feed.php?110,replies=1,type=rss')->getEffectiveUrl();

https://github.com/guzzle/guzzle/blob/5.3/src/Url.php
@jtojnar
Copy link
Member Author

jtojnar commented Jan 24, 2019

Can confirm this is fixed on Guzzle 6, but we cannot switch to it until Graby does: j0k3r/graby#128

@jtojnar jtojnar mentioned this issue Jan 25, 2019
Merged
8 tasks
@jtojnar jtojnar added this to the 2.19 milestone Jan 26, 2019
@jtojnar
Copy link
Member Author

jtojnar commented Jan 26, 2019

Fixed by #1082

@jtojnar jtojnar closed this as completed Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug upstream issue
Projects
None yet
Milestone
2.19
Development

No branches or pull requests
1 participant
@jtojnar