-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server sending invalid dates #1246
Comments
Thanks for reporting. Could you try dumping the date using the following patch? diff --git a/assets/js/templates/Item.jsx b/assets/js/templates/Item.jsx
index 275365ae..7c386541 100644
--- a/assets/js/templates/Item.jsx
+++ b/assets/js/templates/Item.jsx
@@ -295,6 +295,8 @@ export default function Item({ item, selected, expanded, setNavExpanded }) {
const relDate = selfoss.ui.datetimeRelative(item.datetime);
const shares = selfoss.shares.getAll();
+ console.log(item.datetime);
+
return (
<div data-entry-id={item.id}
data-entry-source={item.source} Or adding debugger breakpoint to the affected line selfoss/assets/js/templates/Item.jsx Line 301 in 6fb9a65
and checking what the date is that way? By the way, which development build do you have? And do you use offline mode? |
The r is a known regression, just forgot about it. Sorry, will push a fix soon. |
Date constructor will not fail when invalid date is supplied but it will construct an invalid Date object. The object will then raise an exception when trying to stringify it. Let’s fail early instead. See #1246
Actually, just dumping the value will probably not give us enough info. I pushed a change that hopefully will: fce8eaf |
By switching to route-driven navigation when porting to React, reload action became a no-op. Let’s fix that by explicitly reseting the EntriesPage state. Mentioned in #1246
The r shortcut should be now fixed at least. |
Thank you, I'm confirming "r" now works and navigation panel doesn't disappear when items are in list - so far so good. After loading the page, items are still not displayed and I have redish error message: Chyba načítání: Invalid date detected: “2021-02-16 22:45:05+01” The problem IMHO is "+01" in the date, but you are the developer. :-) |
The |
Thanks again for reporting, I just pushed a fix. It should work with all three supported database engines according to my tests. |
Works perfectly, thx. :-) |
Hello,
I have problems with development builds in firefox. If the list of articles is empty, I see the gui, but when there is at least one article, i see only background (in all window sizes):
In console I see "invalid date" errors.
In Edge selfoss more or less works. (ie. "R" for reload does not work, but I don't know, if it worked before, I only used Edge for test.)
The text was updated successfully, but these errors were encountered: