Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High priority] Use old-style import to fix FOSSA workflows #23

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

shubham1172
Copy link
Contributor

Recently a change was introduced which has impacted repositories using this action via its main branch.

This PR reverts the node: style import to the old way, which is compatible with popular build agents.
Additionally, I ran yarn --frozen-lockfile and yarn build to regenerate ./dist.

Sample action run where it is working: https://github.com/shubham1172/dapr/runs/6061045569?check_suite_focus=true

Closes #22

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Copy link
Contributor Author

@Serubin, @liftM can you please have a look at this?

@himynameisdave himynameisdave merged commit f61a4c0 into fossas:main Apr 20, 2022
@himynameisdave
Copy link
Contributor

@shubham1172 thanks for fixing this, it was an oversight on my part. Just going to test these changes before cutting a new release.

@himynameisdave
Copy link
Contributor

@shubham1172 this has been released in https://github.com/fossas/fossa-action/releases/tag/v1.3.0. Thanks again, you're a life saver!

@shubham1172
Copy link
Contributor Author

Thank you for your quick help @himynameisdave! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs undefined reading createWriteStream
2 participants