Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm WARN deprecated bower@1.8.2 ... migrating to Yarn #10937

Closed
pixelliquid opened this issue Feb 13, 2018 · 11 comments
Closed

npm WARN deprecated bower@1.8.2 ... migrating to Yarn #10937

pixelliquid opened this issue Feb 13, 2018 · 11 comments
Assignees
Labels

Comments

@pixelliquid
Copy link

pixelliquid commented Feb 13, 2018

How to reproduce this bug:

  1. fire up Terminal
  2. npm install --global foundation-cli

What should happen:

installation foundation-cli

What happened instead:

installation foundation-cli failed with deprecated message:
npm WARN deprecated bower@1.8.2: ...psst! Your project can stop working at any moment because its dependencies can change. Prevent this by migrating to Yarn: https://bower.io/blog/2017/how-to-migrate-away-from-bower/

Foundation Version(s) you are using: 6.4

Do we need to take action on this?

@DanielRuf
Copy link
Contributor

bower is dead. We will probably move the dependency to npm.

npm and yarn are not API compatible and use different lock files. We can not manage 2 lock files and package managers at the same time (I guess so).

@ncoden
Copy link
Contributor

ncoden commented Feb 14, 2018

@DanielRuf See yarnpkg/yarn#3614, there's some interesting discussions up there.

@DanielRuf
Copy link
Contributor

There is still no decision afaik yarnpkg/yarn#3614 (comment)

@ncoden
Copy link
Contributor

ncoden commented Feb 14, 2018

Yeah but some solutions:

To anyone who's intersted, I created a small tool that can convert package-lock.json to yarn.lock and vice versa. Would love to know if it works out for you: https://github.com/imsnif/synp
-- yarnpkg/yarn#3614 (comment)

My scenario was to generate package-lock.json file for project where there is already yarn.lock file for longer period of time (and newer versions of dependencies exist). Therefore I've used npm-shrinkwrap to generate lock file for current node_modules tree (installed by yarn). npm install would generate lock file with possibly newer versions of packages. And the trick is that npm-shrinkwrap.json has same structure as package-lock.json (excepts some metadata that are added by npm install at the end).
-- yarnpkg/yarn#3614 (comment)

@DanielRuf
Copy link
Contributor

DanielRuf commented Feb 14, 2018

Wouldn't we then have to purge one of them regularly and reconvert / regenerate it?
I would prefer the way package-lock.json ~> yarn.lock

@ncoden
Copy link
Contributor

ncoden commented Feb 14, 2018

We would have to do that only when we would like to update our dependencies. Why package-lock.json ~> yarn.lock ?

@DanielRuf
Copy link
Contributor

DanielRuf commented Feb 15, 2018

The merge-policy --ours may be useful then.

Because npm has a wider adoption and less issues and shrinkwrap and package-lock are more battle tested than yarn.lock and already longer available.

But it is just my opinion on managing both dependency managers.

@ncoden
Copy link
Contributor

ncoden commented Feb 15, 2018

Because npm has a wider adoption and less issues and shrinkwrap and package-lock are more battle tested than yarn.lock and already longer available.

👍 fair enough

@colin-marshall
Copy link
Contributor

Related: foundation/foundation-cli#87

@ncoden is it appropriate for this issue to remain open here on the foundation-sites repo since it is about the foundation-cli which requires bower for foundation-apps and foundation-emails?

@DanielRuf DanielRuf self-assigned this Mar 1, 2018
@DanielRuf
Copy link
Contributor

We can easily switch to npm. Shall I provide some PRs?

@ncoden
Copy link
Contributor

ncoden commented Mar 1, 2018

Following the @colin-marshall's comment, closing this in favor of foundation/foundation-cli#87

@ncoden ncoden closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants