Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-enable yul settings sanitization #122

Merged
merged 2 commits into from
May 13, 2024
Merged

fix: re-enable yul settings sanitization #122

merged 2 commits into from
May 13, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented May 10, 2024

@klkvr klkvr requested review from DaniPopes and Evalir as code owners May 10, 2024 14:23
@klkvr klkvr requested a review from mattsse May 10, 2024 14:26
mattsse
mattsse approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, omitting them is better than failing

@mattsse mattsse merged commit b0c9baf into main May 13, 2024
13 of 14 checks passed
@DaniPopes DaniPopes deleted the klkvr/fix-yul branch May 13, 2024 17:51
@klkvr klkvr mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge build compile the YUL file with the error Field "settings.remappings" cannot be used for Yul.
2 participants
@klkvr @mattsse