fix: allow empty modifier body in AST #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah accidentally pushed by wip commit with smarter settings configuration upd: should be good for review |
klkvr
force-pushed
the
klkvr/fix-ast-modifier
branch
from
96e0948 to
50eb1de
Compare
klkvr
force-pushed
the
klkvr/fix-ast-modifier
branch
from
50eb1de to
11a98e0
Compare
mattsse
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes foundry-rs/foundry#7554
solc since 0.6.7 allows empty
bodyon modifiersthis was incorrect in OpenZeppelin AST impl which served as a reference for our implementation OpenZeppelin/solidity-ast#43