Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more user-friendly error when no compiler is available #185

Merged
merged 2 commits into from
Aug 4, 2024
Merged

feat: more user-friendly error when no compiler is available #185

merged 2 commits into from
Aug 4, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Aug 4, 2024

Currently, if no Vyper or Solidity compiler is available, returned error would look like:

Found incompatible Solidity versions:
src/a.vy  imports:
    src/b.vy 
Found incompatible Solidity versions:
src/b.vy  imports:
...

This PR adds logic for catching case when the error is caused by missing compiler for the language

@klkvr klkvr requested review from DaniPopes and mattsse as code owners August 4, 2024 06:42
@mattsse mattsse merged commit ec205aa into main Aug 4, 2024
15 checks passed
@DaniPopes DaniPopes deleted the klkvr/better-error-no-compiler branch August 4, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klkvr @mattsse @DaniPopes