Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more test in report/compiler.rs and Default trait for CompilerInput #19

Merged
merged 7 commits into from
Nov 10, 2023
Merged

more test in report/compiler.rs and Default trait for CompilerInput #19

merged 7 commits into from
Nov 10, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

No description provided.

Evalir
Evalir requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more tests always better

pending nits & ci

src/report/compiler.rs Outdated Show resolved Hide resolved
src/report/compiler.rs Outdated Show resolved Hide resolved
src/report/compiler.rs Outdated Show resolved Hide resolved
@Evalir
Copy link
Member

Evalir commented Nov 10, 2023

ping @DoTheBestToGetTheBest

@DoTheBestToGetTheBest
Copy link
Contributor Author

ping @DoTheBestToGetTheBest

Thank you for pinging me, going to check this !

@DoTheBestToGetTheBest
Copy link
Contributor Author

DoTheBestToGetTheBest commented Nov 10, 2023 •
edited
Loading

sorry for the late time, does this look good to you ?

mattsse
mattsse requested changes Nov 10, 2023
View reviewed changes
src/artifacts/mod.rs Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

src/report/compiler.rs Outdated Show resolved Hide resolved
@mattsse
Copy link
Member

mattsse commented Nov 10, 2023

needs cargo +nightly fmt

Evalir
Evalir approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DoTheBestToGetTheBest
Copy link
Contributor Author

ty @mattsse and @Evalir

@Evalir Evalir merged commit 0fc9af7 into foundry-rs:main Nov 10, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DoTheBestToGetTheBest @Evalir @mattsse