Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for unicode width in error syntax highlighting #40

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

DaniPopes
Copy link
Member

No description provided.


pub mod error;
#[allow(ambiguous_glob_reexports)]
pub use error::*;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's 3 different SourceUnit in this module.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I was only able to find

struct SourceUnit {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, SourceLocation

@DaniPopes DaniPopes marked this pull request as ready for review January 6, 2024 12:21
@DaniPopes DaniPopes requested a review from Evalir as a code owner January 6, 2024 12:21
@DaniPopes DaniPopes requested a review from mattsse January 6, 2024 12:21
@DaniPopes DaniPopes merged commit 952bf64 into main Jan 6, 2024
20 checks passed
@DaniPopes DaniPopes deleted the dani/fix-error-fmt branch January 6, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants