Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small flattener features #75

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Small flattener features #75

merged 4 commits into from
Feb 13, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Feb 13, 2024

This PR implements two small flattener features mentioned in makerdao/spells-mainnet#391 (comment)

  1. Combine pragmas from different sources into one pragma so that version restrictions are kept the same before and after flattening
  2. Comments specifying original source file of the flattened code (// src/File.sol)

mattsse
mattsse approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Cargo.toml Outdated Show resolved Hide resolved
@mattsse mattsse merged commit 990c609 into foundry-rs:main Feb 13, 2024
14 checks passed
@klkvr klkvr mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klkvr @onbjerg @mattsse